-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement broadcasting for BioSequences #171
base: v3
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## v3 #171 +/- ##
==========================================
- Coverage 82.16% 81.97% -0.19%
==========================================
Files 31 32 +1
Lines 2159 2164 +5
==========================================
Hits 1774 1774
- Misses 385 390 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@jakobnissen Ok so, because broadcasting is a bit complex, I'm going to properly document every choice I make, and everything I've learned so far about the machinery here, as I make commits. |
Looks good! I'll follow from the sidelines :) |
5d7692e
to
2865850
Compare
If you get to understand how broadcasting works, can you perhaps check this method ambiguity out?
Is this a runtime error waiting to happen or is it OK? |
I've cleared this from the v3.0 milestone, we're officially gonna push this back to a version 3.X. |
Can you rebase this on master? (no rush though) |
Types of changes
This PR implements the following changes:
(Please tick any or all of the following that are applicable)
☑️ Checklist
docs/src/
.[UNRELEASED]
section of the manually curatedCHANGELOG.md
file for this repository.