Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge cases #4

Open
btupper opened this issue Jan 10, 2022 · 4 comments
Open

Edge cases #4

btupper opened this issue Jan 10, 2022 · 4 comments

Comments

@btupper
Copy link
Member

btupper commented Jan 10, 2022

Currently, a particle can drift beyond the extent of the elements (either goes ashore or drifts beyond the open water edge. Is that what we want?

@SeascapeScience
Copy link

Does it happen frequently along the coast? Or more at the open boundaries? If it's just the open boundaries, no problem.

Another option would be to clip it to the edge if it drifts out.

@btupper
Copy link
Member Author

btupper commented Jan 11, 2022

Clipping is how it works now - for the track that exits it is "done", but the while loop continues for all other tracks until they all exit or the max iteration is reached.
MassBay_track
You can see that two exited early (short orange to south and the long green to the north) but the third (blue) reached that max iteration.

@SeascapeScience
Copy link

Short orange looks like it could be a problem. Can we clip it back to the nearest in-domain location? I have to think about that.

@btupper
Copy link
Member Author

btupper commented Jan 11, 2022

All points are in the domain. If “next” point is out then the iteration stops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants