Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech Profile page improvements #979

Closed
7 tasks done
mdmohsin7 opened this issue Oct 5, 2024 · 2 comments
Closed
7 tasks done

Speech Profile page improvements #979

mdmohsin7 opened this issue Oct 5, 2024 · 2 comments
Assignees
@mdmohsin7

Comments

@mdmohsin7
Copy link
Collaborator

mdmohsin7 commented Oct 5, 2024 •
edited
Loading

  • UI empty is really bad, an empty white line at the bottom.

  • Explain probably that language is only english, yea some people might have confused.

  • Page overall feels a bad initial experience.

  • Multiple speakers validation only happens if more than 20 words

  • "Try again" when multiple speakers is not triggering correctly

  • 150 seconds limit instead of 90, and when get to it, show a different message like "Are you still there?" instead of "Invalid speech .... " Explain that it took them too long so they will have to restart, if they did 80% of the words, let them go through.

  • On getting started page mention that this works only for english.

Image
@mdmohsin7 mdmohsin7 self-assigned this Oct 5, 2024
@mdmohsin7 mdmohsin7 converted this from a draft issue Oct 5, 2024
@kodjima33 kodjima33 moved this from In progress to Backlog in omi TODO Oct 5, 2024
@mdmohsin7 mdmohsin7 mentioned this issue Oct 6, 2024
Merged
6 tasks
josancamon19 added a commit that referenced this issue Oct 8, 2024
@josancamon19
Speech Profile Page Improvements (#971)
14ae1d1 
Related to #979 
- [x] On getting started page mention that this works only for english.
- [x] 150 seconds limit instead of 90, and when get to it, show a
different message like "Are you still there?" instead of "Invalid speech
.... " Explain that it took them too long so they will have to restart,
if they did 80% of the words, let them go through.
- [x] "Try again" when multiple speakers is not triggering correctly
- [x] Multiple speakers validation only happens if more than 20 words
(reduced it to 8 words)
- [x] Explain probably that language is only english, yea some people
might have confused.
- [x] UI empty is really bad, an empty white line at the bottom.


https://github.com/user-attachments/assets/7f585fab-bca8-4924-a6a4-7de72faffe6e


https://github.com/user-attachments/assets/02b80197-a359-4159-a3b3-3ff883b8b839




<!-- This is an auto-generated comment: release notes by OSS
Entelligence.AI -->
### Summary by Entelligence.AI

- New Feature: Enhanced the user interface of the `SpeechProfilePage`
with improved progress bar display and text styling.
- Refactor: Updated the `SpeechProfileProvider` class to increase the
maximum duration from 90 to 150 and target words count to 60, providing
a more flexible speech profile creation process.
- Bug Fix: Improved error notifications and conditions for detecting
multiple speakers in the `SpeechProfileProvider`, enhancing the accuracy
of speech analysis.
- Chore: Removed the unused `MemoryCreatedWidget` from the
`_OnboardingWrapperState` class, optimizing the rendering performance.
<!-- end of auto-generated comment: release notes by OSS Entelligence.AI
-->
@beastoin
Copy link
Collaborator

@mdmohsin7 youuuu forgot to update?

@mdmohsin7
Copy link
Collaborator Author

@mdmohsin7 youuuu forgot to update?

Updated sir

@github-project-automation github-project-automation bot moved this from In review to Done in omi TODO Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmohsin7 mdmohsin7

Labels
None yet
Projects
omi TODO
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beastoin @mdmohsin7