Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the capture memory logic in the app's codebase #862

Closed
3 tasks done
beastoin opened this issue Sep 17, 2024 · 0 comments
Closed
3 tasks done

Clean up the capture memory logic in the app's codebase #862

beastoin opened this issue Sep 17, 2024 · 0 comments
Assignees
@beastoin

Comments

@beastoin
Copy link
Collaborator

beastoin commented Sep 17, 2024 •
edited
Loading

Actions:

  • New memory by Friend device(not Openglass) is created from the backend side, there are no need maintain that logic in the app anymore.
  • Openglass, Frame device is create new memory from app, so maintaining that logic for these devices.
  • Double check the Dev mode, sync audio to GCP. Keep it works.
@beastoin beastoin self-assigned this Sep 17, 2024
@beastoin beastoin converted this from a draft issue Sep 17, 2024
@kodjima33 kodjima33 moved this from In progress to Backlog in omi TODO Sep 17, 2024
@beastoin beastoin mentioned this issue Sep 17, 2024
Merged
beastoin added a commit that referenced this issue Sep 17, 2024
@beastoin
Clean capture provider, remove create new memory from transcrip segme… (
1d57a37 
#870)

Issue: #862 


<!-- This is an auto-generated comment: release notes by OSS
Entelligence.AI -->
### Summary by Entelligence.AI

- Refactor: Updated the method call in `_MemoryCaptureWidgetState` class
from `tryCreateMemoryManually()` to `createMemory()`, enhancing the
memory creation process.
- Refactor: Simplified the `processTranscriptContent` function by
removing the dependency on `TranscriptSegment`. This change streamlines
the processing of transcript content, improving performance and
maintainability.
- Bug Fix: Adjusted the logic for handling empty transcript segments in
the `processTranscriptContent` function, ensuring correct behavior when
no segments are provided.
<!-- end of auto-generated comment: release notes by OSS Entelligence.AI
-->
@github-project-automation github-project-automation bot moved this from In progress to Done in omi TODO Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beastoin beastoin

Labels
None yet
Projects
omi TODO
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beastoin