Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summarization language #823

Closed
Blueforcer opened this issue Sep 12, 2024 · 5 comments
Closed

Summarization language #823

Blueforcer opened this issue Sep 12, 2024 · 5 comments

Comments

@Blueforcer
Copy link

Blueforcer commented Sep 12, 2024

Is your feature request related to a problem? Please describe.
While I can set the speech recognition to German, the summary and "Abouts" are still written in English.

Describe the solution you'd like
LLM should output in the same language as the input language

Describe alternatives you've considered
It should be possible to realize this with a extended prompt. like
"Write in [selected language]"..

@azdolinski
Copy link

+1
It is doing Polish transcript.. but summary is in English.

@josancamon19
Copy link
Contributor

Hi, thanks for posting, but this is not planned for now.

@josancamon19 josancamon19 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
@Blueforcer
Copy link
Author

Can you explain this decision?
Changing "Use English for your response." to "Use {language_code} for your response". should do the trick. Maybe just optional?

The conversation language is {language_code}. Use English for your response.

@azdolinski
Copy link

azdolinski commented Sep 26, 2024

I agree with @Blueforcer. By closing this, you are showing ignorance to the rest of the “non-English speaking” world and drastically limiting the scope of the product to people who only use English - where this change can easily be made by adding an additional {language_response} parameter injected into the get_transcript_structure prompt and allowing the same settings/variable to be used in plugin prompts.

@kodjima33 - can you share your opinion?
On behalf of other countries that use ie. PL, DE, ES, ZH, HI

@wHyEt
Copy link

wHyEt commented Sep 26, 2024

@josancamon19 I don't get why this is closed this is a highly needed feature since this product is used all over the world

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants