Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish setting up codemagic #525

Closed
josancamon19 opened this issue Aug 5, 2024 · 7 comments
Closed

Finish setting up codemagic #525

josancamon19 opened this issue Aug 5, 2024 · 7 comments
Assignees

Comments

@josancamon19
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@kodjima33 kodjima33 moved this to Backlog in omi TODO Aug 5, 2024
@legut2
Copy link

legut2 commented Aug 8, 2024

I'm interested in helping out with this but it's a duplicate of this issue in some sense. I even suggested it on there. The reason I suggested it is because codemagic is designed around flutter and when I looked at fast lane - it didn't feel like it was designed with consideration of flutter at all. Which is a really nuanced but important detail for developer experience in my opinion.

@josancamon19
Copy link
Contributor Author

Awesome, thank you.

Assigning to @legut2

@josancamon19
Copy link
Contributor Author

There's an intiial implementation, please DM me your email on discord to give you access to codemagic org.
We are also using shorebird right now, do you know if there is a way to do shorebird but if we modified native code, to do the full release? @legut2 ?

@legut2
Copy link

legut2 commented Aug 9, 2024

There's an intiial implementation, please DM me your email on discord to give you access to codemagic org.

We are also using shorebird right now, do you know if there is a way to do shorebird but if we modified native code, to do the full release? @legut2 ?

I'm not familiar with shorebird and I cannot say. Can you point me to where that integration exists relating to this repo? Looks like there is a config file here.

DM'd you on discord and linked this issue.

@yashas-hm
Copy link

Hi,

Is this implemented?

@legut2
Copy link

legut2 commented Aug 21, 2024

@yashas-hm I am uncertain. I haven't received access from @josancamon19. I am unable to make any kind of progress on this. It's very confusing why there is an issue for fast lane, an issue for codemagic, but they're using shorebird? Those feel like competing issues that needlessly overlap in functionality and accomplish similar goals.

@yashas-hm
Copy link

@legut2 According to what I have read on #298 and this issue, they have already implemented Shorebird and wanted to setup automated deployments but there is some confusion between fastlane and codemagic.
Shorebird is used for on the fly changes like minor bug fixes or text changes etc. of sorts but shouldn't be used to introduce new features or a major change.
For major changes and new features automated deployment would be preferable (creating & publishing a new release) hence implementing both shorebird and automated deployment makes sense.
I would recommend using codemagic over fastlane as codemagic was built taking flutter into mind and fastlane is a general ci/cd tool. Also Codemagic has a huge community for flutter support.

@josancamon19 please correct me if i'm wrong understanding the issues.
Thank you

@josancamon19 josancamon19 assigned beastoin and unassigned legut2 Aug 24, 2024
beastoin added a commit that referenced this issue Aug 26, 2024
Issue: #525

Use Codemagic on CI/CD, target iOS/Android

#  Checklist
 - [x] Release Android to Internal Test
 - [x] Release iOS to Testflight

# Todos
- [x] Setup Personal Project codemagic
- [x] Draft Android to Internal Test, focus on building process
- [x] Draft iOS to Testflight, focus on building process
- [x] Trigger Tags , https://github.com/BasedHardware/Omi/tags 
- [x] Use Cache to speed up deployment process
- [x] Transfer Codemagic Omi App to Team
- [ ] (Next) Re-use script with definitions
- [ ] (Next) Dont use tricky on Opus Android







<!-- This is an auto-generated comment: release notes by OSS
Entelligence.AI -->
### Summary by Entelligence.AI

- Chore: Updated Android signing configuration to support Codemagic
CI/CD. This change allows for seamless integration and deployment using
Codemagic's environment.
- Refactor: Set the `ndkVersion` to "27.0.12077973" for Android NDK.
This ensures consistency in the build process across different
environments, leading to more reliable builds.

<!-- end of auto-generated comment: release notes by OSS Entelligence.AI
-->
@github-project-automation github-project-automation bot moved this from In review to Done in omi TODO Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants