Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend Websocket in modal has a lot of disconnect bugs reports #515

Closed
josancamon19 opened this issue Aug 3, 2024 · 3 comments
Closed

Backend Websocket in modal has a lot of disconnect bugs reports #515

josancamon19 opened this issue Aug 3, 2024 · 3 comments
Assignees
@beastoin
Labels
backend Backend Task (python) Paid Bounty 💰 task

Comments

@josancamon19
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When you deploy the backend to modal, we get a lot of errors as if the Websocket had a lot of issues, but what's happening is a disconnect error, this is mainly a backend task, to make sure the disconnection is handled properly, and the errors in modal are not triggered.

When this is fixed, we should be able to handle gracefully app Websocket disconnections.

CleanShot 2024-08-02 at 18 23 55@2x
CleanShot 2024-08-02 at 18 24 03@2x
CleanShot 2024-08-02 at 18 24 18@2x
CleanShot 2024-08-02 at 18 24 26@2x
@kodjima33 kodjima33 moved this to Backlog in omi TODO Aug 3, 2024
@D1ll4nT
Copy link

D1ll4nT commented Aug 7, 2024

I committed some code that should improve the stability. I don't have the credentials thought so I can't test it. Do you mind testing it to see if it performs better?

@josancamon19
Copy link
Contributor Author

Hey, @D1ll4nT happy to review, pls change your PR to Draft PR, and please deploy the backend to your own modal, it should be easier to test that way.

@josancamon19
Copy link
Contributor Author

Assigning to you for the next 2 days @D1ll4nT

@github-project-automation github-project-automation bot moved this from Backlog to Done in omi TODO Aug 15, 2024
@josancamon19 josancamon19 reopened this Aug 15, 2024
@josancamon19 josancamon19 assigned josancamon19 and unassigned D1ll4nT Aug 15, 2024
@josancamon19 josancamon19 changed the title Backend Websocket in modal has a lot of disconnect bugs reports ($200) Backend Websocket in modal has a lot of disconnect bugs reports Aug 15, 2024
@beastoin beastoin mentioned this issue Aug 27, 2024
Merged
beastoin added a commit that referenced this issue Aug 27, 2024
@beastoin
Updates: Wrap(actually try-catch) web socket to prevent dirty receive (…
d6379d4 
…#674)

Issue: #515

<!-- This is an auto-generated comment: release notes by OSS
Entelligence.AI -->
### Summary by Entelligence.AI

- Bug Fix: Improved error handling in the transcription service. We've
added a safeguard to ensure that if an unexpected issue occurs during
the initiation of a transcription session, the system will now handle it
gracefully and close the session properly. This enhancement increases
the robustness of our transcription service and provides a better user
experience.
<!-- end of auto-generated comment: release notes by OSS Entelligence.AI
-->
@beastoin beastoin moved this from In review to Done in omi TODO Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beastoin beastoin

Labels
backend Backend Task (python) Paid Bounty 💰 task
Projects
omi TODO
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beastoin @josancamon19 @D1ll4nT