Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memories Include location of the memory ($100) #384

Closed
josancamon19 opened this issue Jun 30, 2024 · 5 comments · Fixed by #439
Closed

Memories Include location of the memory ($100) #384

josancamon19 opened this issue Jun 30, 2024 · 5 comments · Fixed by #439
Assignees

Comments

@josancamon19
Copy link
Contributor

josancamon19 commented Jun 30, 2024

Is your feature request related to a problem? Please describe.
Location, should simply store Lat Lng of where the memory was created.

And should be displayed beautifully on the memory detail page, with a onClick to maps.

Sort of.
IMG_0001

  • Update memory database object.
  • Make this coordinates array, optional.
  • If available display them on memory detail page.
@kodjima33 kodjima33 moved this to Backlog in omi TODO Jun 30, 2024
@josancamon19 josancamon19 changed the title [DRAFT] Memories Include relevant links + location details Memories Include location of the memory Jun 30, 2024
@josancamon19 josancamon19 changed the title Memories Include location of the memory Memories Include location of the memory ($100) Jun 30, 2024
@josancamon19
Copy link
Contributor Author

Location permissions should be asked seamlessly.

@kodjima33 kodjima33 removed the status in omi TODO Jul 1, 2024
@mdmohsin7
Copy link
Collaborator

mdmohsin7 commented Jul 2, 2024

We have to fetch the user's location only once? Or keep fetching it every few mins or something like that?

@josancamon19
Copy link
Contributor Author

josancamon19 commented Jul 3, 2024

Only once, lgtm, where the memory starts probably @mdmohsin7

@mdmohsin7
Copy link
Collaborator

Only once, lgtm, where the memory starts probably @mdmohsin7

Wouldn't it make more sense to ask for location (only once) when the user starts recording? As the user will have to interact with the App (especially on iOS) for location (if they only allow one time access). We will have to wait until the user interacts with the location popup before we can start creating a memory.

Also @josancamon19 would like to take this up. I've started working on it.

@josancamon19
Copy link
Contributor Author

Yeah, let's ask only once, what I mean is let's try obtaining the location only where the memory starts.

@josancamon19 josancamon19 moved this to Backlog in omi TODO Jul 15, 2024
@josancamon19 josancamon19 moved this from Backlog to In progress in omi TODO Jul 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in omi TODO Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants