Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate One Signal ($100) #331

Closed
josancamon19 opened this issue Jun 21, 2024 · 14 comments · Fixed by #344
Closed

Integrate One Signal ($100) #331

josancamon19 opened this issue Jun 21, 2024 · 14 comments · Fixed by #344
Assignees

Comments

@josancamon19
Copy link
Contributor

Is your feature request related to a problem? Please describe.
https://documentation.onesignal.com/docs/flutter-sdk-setup

We should be able to send updates, notifications, or anything through push notifications to user, about important updates, deals, etc.

Describe the solution you'd like
Implement OneSignal integration + user identification on main.dart

Additional context
I spent a few hours trying to set it up but this issue always came: https://github.com/OneSignal/OneSignal-Flutter-SDK/issues?q=Multiple+commands+produce

@taaha161
Copy link

Hello, can I be assigned this task?

@josancamon19
Copy link
Contributor Author

Assigning to @taaha161 for the next 2 days, please create a draft PR and keep updating your owkr

@mdmohsin7
Copy link
Collaborator

mdmohsin7 commented Jun 22, 2024

Hi @josancamon19 I have integrated One SIgnal and have tested it on Android. It is working as expected. I also have fixed the multiple commands produce error. I currently don't have a paid Apple Developer Account so I am unable to build the iOS App locally (signing issues due to push notifications requiring paid account). Should I open a draft PR so that you can test the build out locally?

@josancamon19
Copy link
Contributor Author

The complex part is iOS unfortunately, not android, so if you can't I will deassign the PR, please let me know

@mdmohsin7
Copy link
Collaborator

The complex part is iOS unfortunately, not android, so if you can't I will deassign the PR, please let me know

Understood! I wasn't assigned this issue anyway. I just started working on it directly. I have shared the fix for the multiple commands produce error in the comment of the GitHub issue link you've attached. You can follow those steps to fix that issue and complete the integration.
OneSignal/OneSignal-Flutter-SDK#551 (comment)

@josancamon19
Copy link
Contributor Author

Thanks @mdmohsin7 , I'll give it a try in a couple hours and will let you know.

@josancamon19
Copy link
Contributor Author

Tried but still no progress, can I assign it to you, please send me an email with your details to [email protected], I will give you access to our AppStore team.

@mdmohsin7
Copy link
Collaborator

mdmohsin7 commented Jun 22, 2024

Tried but still no progress

Strange! Are you still getting the same multiple commands produce error or a new cyclic dependency error? If it's the same error, is it for One Signal specific files only?

can I assign it to you, please send me an email with your details to [email protected], I will give you access to our AppStore team.

Sure! I can try. What all details do I have to email?

@josancamon19
Copy link
Contributor Author

Just your email @mdmohsin7

@mdmohsin7
Copy link
Collaborator

Just your email @mdmohsin7

Done! I've sent you an email with the subject One Signal Integration #331

@josancamon19 josancamon19 assigned mdmohsin7 and unassigned taaha161 Jun 23, 2024
@mdmohsin7
Copy link
Collaborator

mdmohsin7 commented Jun 23, 2024

@josancamon19 after a lot of errors and problems, I finally got the app to build alongside the OneSignal integration. Can you please share the app id for iOS from One Signal dashboard which you might have setup already? Or should I set it up on my personal OneSignal account for testing?

Update: I checked the Apple Developer Console and didn't find any keys, which means OneSignal wasn't setup. So I created a p8 Key and integrated APN in my personal OneSignal Account and tested it.
Attaching screenshot of the test notification I sent as a proof.

notification

@mdmohsin7
Copy link
Collaborator

@josancamon19 what values do we have to use to identify users?

var externalId = "123456789" // You will supply the external id to the OneSignal SDK
OneSignal.login(externalId);

@josancamon19
Copy link
Contributor Author

Awesome! you can use Sharedprefs.uid, could you please create a PR for this? so we can merge it today? thanks!

@josancamon19
Copy link
Contributor Author

Also, please DM me your details for the transfer, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants