fix: add support for merged so libraries #663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okwasniewski
commented
Nov 26, 2024
| @@ -62,9 +62,6 @@ buildscript { | |||
| } | |||
|
|
|||
| def graphics_api = safeExtGet('GRAPHICS_API', "OpenGL") | |||
|
|
|||
| apply plugin: 'com.android.library' | |||
There was a problem hiding this comment.
This was duplicated
|
This PR will become irrelevant once AAR support is included so probably can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR adds support for React Native 0.76 merged .so libraries, reference: react-native-community/discussions-and-proposals#816
Documentation
N/A
Testing
Try to build the app for 0.76
The app is built properly but Im getting corrupted stack issues, both on 0.75 (without merged so) and 0.76 (with merged so) but this is mostly build-related change so verifying if the library builds properly is the most important step. I'm looking into the corrupted stack issues