Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main thread is blocked when rendering #343

Closed
bghgary opened this issue Feb 17, 2022 · 1 comment · May be fixed by #630
Closed

Main thread is blocked when rendering #343

bghgary opened this issue Feb 17, 2022 · 1 comment · May be fixed by #630
Milestone
8.0

Comments

@bghgary
Copy link
Contributor

bghgary commented Feb 17, 2022 •
edited
Loading

See

BabylonReactNative/Modules/@babylonjs/react-native/shared/BabylonNative.cpp

Lines 116 to 119 in b3716d9

g_graphics->StartRenderingCurrentFrame();
g_update->Start();
g_update->Finish();
g_graphics->FinishRenderingCurrentFrame();

The code is currently calling FinishRenderingCurrentFrame immediately following StartRenderingCurrentFrame. FinishedRenderingCurrentFrame will immediately block waiting for the JS thread to finish doing its part. Ideally, these calls should be backwards. StartRenderingCurrentFrame should be called as soon as possible and FinishRenderingCurrentFrame should be called as late as possible. There should be a small gap between FinishRenderingCurrentFrame and the next StartRenderingCurrentFrame.
@bghgary bghgary mentioned this issue Feb 17, 2022
Closed
@thomlucc thomlucc added the 6.0 label Sep 23, 2022
@thomlucc thomlucc added this to the 6.0 milestone Sep 23, 2022
@thomlucc thomlucc removed the 6.0 label Sep 23, 2022
@thomlucc thomlucc modified the milestones: 6.0, 7.0 Mar 21, 2023
@ryantrem ryantrem mentioned this issue Jun 6, 2023
Closed
@CedricGuillemet CedricGuillemet mentioned this issue Jan 8, 2024
Draft
@thomlucc thomlucc modified the milestones: 7.0, 8.0 Apr 2, 2024
@bghgary
Copy link
Contributor Author

bghgary commented Sep 10, 2024

Closing in favor of #1416

@bghgary bghgary closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Swap start/finish order for rendering ryantrem/BabylonReactNative
2 participants
@bghgary @thomlucc