Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run the Layout-Aware example #87

Open
vmetodiev opened this issue Jul 8, 2023 · 2 comments
Open

Cannot run the Layout-Aware example #87

vmetodiev opened this issue Jul 8, 2023 · 2 comments

Comments

@vmetodiev
Copy link

On the latest master branch commit, even if gdsfactory is installed, upon trying to run the "Layout-Aware Monte Carlo Simulations for Yield Estimation" example from the official documentation page, I get:

2023-07-08 18:51:59.778 | INFO | gdsfactory.config:init:205 - LogLevel: INFO
2023-07-08 18:52:01.503 | WARNING | gdsfactory.types::47 - gdsfactory.types has been renamed to gdsfactory.typings. types will be removed in the near future.
2023-07-08 18:52:01.749 | WARNING | gdsfactory.pdk:get_active_pdk:621 - No active PDK. Activating generic PDK.

2023-07-08 18:52:01.934 | INFO | gdsfactory.technology.layer_views:init:785 - Importing LayerViews from YAML file: '/usr/local/lib/python3.8/dist-packages/gdsfactory/generic_tech/layer_views.yaml'.
2023-07-08 18:52:01.945 | INFO | gdsfactory.pdk:activate:266 - 'generic' PDK is now active
Traceback (most recent call last):
File "sim.py", line 62, in
c = mzi()
File "/usr/local/lib/python3.8/dist-packages/gdsfactory/cell.py", line 186, in _cell
component = func(*args, **kwargs)
File "pydantic/decorator.py", line 40, in pydantic.decorator.validate_arguments.validate.wrapper_function
File "pydantic/decorator.py", line 134, in pydantic.decorator.ValidatedFunction.call
File "pydantic/decorator.py", line 206, in pydantic.decorator.ValidatedFunction.execute
File "sim.py", line 33, in mzi
gc_input["pin1"].connect(y_splitter, gcin, ysplit)
File "/home/ubuntu/Work/Photonics/simphony/simphony/pins.py", line 104, in connect
raise ImportError("gdsfactory is not installed. Try pip install gdsfactory.")
ImportError: gdsfactory is not installed. Try pip install gdsfactory.

_Note: I have created the sim.py file that contains the copy-pasted snippets from the tutorial and is located inside the repo root directory. _

@sequoiap
Copy link
Collaborator

@cjcarver @SkandanC

@sequoiap
Copy link
Collaborator

gdsfactory's API changes frequently, so it's possible that the latest versions of gdsfactory don't work with this example anymore. @SkandanC, any ideas on how far back of a reversion might be required?

I'll also mention that simphony is presently undergoing a pretty major refactoring to be released as v0.7.0 (and it will be incompatible with previous versions). The new API will be much prettier, in my opinion as the developer, so we probably won't be trying very hard to get the old versions of simphony to work with gdsfactory again but focus our efforts on the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants