Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup style.css for public consumption #453

Open
WorldsEndless opened this issue Apr 19, 2022 · 9 comments
Open

Cleanup style.css for public consumption #453

WorldsEndless opened this issue Apr 19, 2022 · 9 comments
Assignees

Comments

@WorldsEndless
Copy link
Contributor

WorldsEndless commented Apr 19, 2022

Currently style.css is about 7000 lines. Can we reduce it to under 1000, including comments?

Remember to check both public pages and the admin dashboard/interface

@spencercheng spencercheng self-assigned this Apr 19, 2022
@spencercheng
Copy link
Contributor

spencercheng commented May 10, 2022

Two options for getting an offline version of HTML classes.
https://www.httrack.com/html/index.html
https://wordpress.org/plugins/simply-static/

Comment out large chunks of styles and add them back in.

@WorldsEndless
Copy link
Contributor Author

using httrack you could download all the final html, and then in vscode you can search it for whether that style class is actually used. Then you can comment it out in the real style.css and, at the end of the day, if things look the same with all the commented-out sections, you can straight up delete them.

@spencercheng
Copy link
Contributor

@WorldsEndless Since there are currently no unassigned tickets, I was wondering if @julianayue could help with this ticket since issue #473 is almost resolved. A suggestion would be I could work on lines 0-4000, while she works on the rest. (4000-6500). What are your thoughts?

@WorldsEndless
Copy link
Contributor Author

sounds great!

@spencercheng
Copy link
Contributor

I found something that looks to be something that could help speed up the process of doing this ticket. In the inspect tool their is a section called coverage, and it lets us know what css styles is being used. The one's in blue means used and the red means it isn't. What are your thoughts? @WorldsEndless
image

@spencercheng
Copy link
Contributor

Check individual pages for different selector uses. Different ways to make it more responsive.

@WorldsEndless
Copy link
Contributor Author

closed by #495

@WorldsEndless
Copy link
Contributor Author

Did these changes go away? There are still over 6000 lines in style.css

@WorldsEndless
Copy link
Contributor Author

@rosesxmarie I believe we talked about this issue, but I forgot to assign it. It is largely a git exploration: what happened to the massive down-sizing that was previously accomplished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants