Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate Callstack Feature #64

Open
5 tasks done
Aragas opened this issue Oct 23, 2022 · 0 comments
Open
5 tasks done

Recreate Callstack Feature #64

Aragas opened this issue Oct 23, 2022 · 0 comments

Comments

@Aragas
Copy link
Member

Aragas commented Oct 23, 2022

Starting from version 4, Crash Reports have the full stacktrace + IL Offsets.
Because we have the ability to get the game's .dll files from Steam and create .pdb files on the fly if needed, we should be able to show the user both the faulty methods and the lines responsible for the fault.

There are some caveats:

  • A game update could break the feature and show an incorrect line. The Crash Report doesn't store the ChangeSet used. We'll need to store the changeset to be sure that the binary is correct for the crash report. If they differ, a warning prompt should be enough.
  • We'll need to either rate limit the feature or cache the game binaries, with invalidation on a game update that we'll need to detect in a way that will only invalidate the updated branch, not all of them
  • Expose the necessary info in CrashReportParser
  • Create a caching layer for the game binaries
  • Extract the source code from methods
  • Apply the IL Offset to the source code
  • Create a page for displaying the source code with the highlighted line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant