Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map and waterflow unittests #14

Merged
merged 6 commits into from
May 22, 2024
Merged

Map and waterflow unittests #14

merged 6 commits into from
May 22, 2024

Conversation

sziki12
Copy link
Contributor

@sziki12 sziki12 commented May 18, 2024

Map Creation, Waterflow and Point Calculation unit tests created.

sziki12 added 4 commits May 17, 2024 22:21
Created common init for tests and Map and WaterFlow test skeleton, progress in implementation
Waterflow, Point Calculation and Map Setup tests
Pipe was leaking water without water in it.
@sziki12 sziki12 self-assigned this May 18, 2024
@sziki12 sziki12 linked an issue May 18, 2024 that may be closed by this pull request
@sziki12 sziki12 requested a review from Abri02 May 18, 2024 18:05
Copy link
Contributor

@Abri02 Abri02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the unit tests in this pull request and found them to be thorough and well-written.

Waterflow function test by invocation count for different elements of the map.
Fix for Pump step, now it correctly calls the step of the neighbour pipes.
Copy link

sonarcloud bot commented May 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Abri02 Abri02 merged commit 99d3857 into main May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit testing deployment and creating new tests
2 participants