Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static analysis #5

Merged
merged 32 commits into from
May 17, 2024
Merged

Static analysis #5

merged 32 commits into from
May 17, 2024

Conversation

Hybeee
Copy link
Contributor

@Hybeee Hybeee commented May 6, 2024

No description provided.

@Hybeee Hybeee linked an issue May 6, 2024 that may be closed by this pull request
Performing Static Analysis On The Project #4
Closed
Hybeee added 26 commits May 6, 2024 20:27
@Hybeee
Nomad class override added
d431574
@Hybeee
triggering sonarcloud test
8b14772
@Hybeee
Character.java analysed
a6ee7d7
@Hybeee
City.java analysed and corrected
d9b923a
@Hybeee
Field.java analysed and corrected
81ec829
@Hybeee
Game.java analysed and corrected
0f78fef
@Hybeee
Mechanic.java analysed and corrected
dc777e9
@Hybeee
Node.java analysed and corrected
f7bf207
@Hybeee
Pipe.java analysed and corrected
df03cad
@Hybeee
Pump.java analysed and corrected
02f0974
@Hybeee
Source.java analysed and corrected
cc397bd
@Hybeee
Step.java analysed and corrected
0d896dd
@Hybeee
CityView.cs analysed and corrected
ad901bd
@Hybeee
IView analysed and corrected
a15cc0c
@Hybeee
IView.java analysed and corrected
d276673
@Hybeee
SourceView.java analysed and updated
098eea4
@Hybeee
PipeView.java and PipeView.java analysed and corrected
631b5bc
@Hybeee
NomadView.java analysed and corrected
d813383
@Hybeee
NodeView.java analysed and corrected
32f3fe6
@Hybeee
MechanicView.java analysed
ad73928
@Hybeee
MechanicView documentation correction
b5f3bee
@Hybeee
GameFrame.java analysed and corrected
c1567ee
@Hybeee
Drawer.java analysed and corrected
27bf787
@Hybeee
TastClass.java analysed
082a769
@Hybeee
TesterMain.java analysed
4e4ee54
@Hybeee
Main.java analysed and corrected
ceb360a
@Hybeee Hybeee requested a review from esztertolm May 8, 2024 18:45
@Hybeee Hybeee self-assigned this May 12, 2024
@KapszulasKaresz KapszulasKaresz self-requested a review May 17, 2024 18:36
KapszulasKaresz
KapszulasKaresz reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@KapszulasKaresz KapszulasKaresz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minden ok

@KapszulasKaresz KapszulasKaresz self-requested a review May 17, 2024 18:37
@Hybeee Hybeee requested review from Stellaway and bohcstams and removed request for KapszulasKaresz May 17, 2024 18:37
@KapszulasKaresz KapszulasKaresz self-requested a review May 17, 2024 18:37
KapszulasKaresz
KapszulasKaresz approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@KapszulasKaresz KapszulasKaresz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minden ok

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Hybeee Hybeee merged commit 5a94911 into main May 17, 2024
4 of 5 checks passed
@Hybeee Hybeee deleted the static-analysis branch May 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KapszulasKaresz KapszulasKaresz KapszulasKaresz approved these changes

@esztertolm esztertolm Awaiting requested review from esztertolm

@Stellaway Stellaway Awaiting requested review from Stellaway

@bohcstams bohcstams Awaiting requested review from bohcstams

Assignees

@Hybeee Hybeee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performing Static Analysis On The Project
2 participants
@Hybeee @KapszulasKaresz