Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop-cluster, terminate-cluster broken #99

Open
adderan opened this issue Feb 10, 2016 · 4 comments
Open

stop-cluster, terminate-cluster broken #99

adderan opened this issue Feb 10, 2016 · 4 comments
Labels

Comments

@adderan
Copy link
Contributor

adderan commented Feb 10, 2016

Traceback (most recent call last):
  File "/home/alden/cgcloud/env/bin/cgcloud", line 9, in <module>
    load_entry_point('cgcloud-core==1.4a1.dev0', 'console_scripts', 'cgcloud')()
  File "/home/alden/cgcloud/core/src/cgcloud/core/cli.py", line 49, in main
    app.run( args )
  File "/home/alden/cgcloud/lib/src/cgcloud/lib/util.py", line 306, in run
    command.run( options )
  File "/home/alden/cgcloud/core/src/cgcloud/core/commands.py", line 81, in run
    return self.run_in_ctx( options, ctx )
  File "/home/alden/cgcloud/core/src/cgcloud/core/cluster_commands.py", line 45, in run_in_ctx
    self.run_on_cluster_type( ctx, options, cluster_type )
  File "/home/alden/cgcloud/core/src/cgcloud/core/cluster_commands.py", line 175, in run_on_cluster_type
    self.run_on_cluster( options, ctx, cluster )
  File "/home/alden/cgcloud/core/src/cgcloud/core/cluster_commands.py", line 296, in run_on_cluster
    pool_size=min(options.num_threads),
TypeError: 'int' object is not iterable

Should this be min(options.num_threads, options.num_workers)?

@adderan adderan added the bug label Feb 10, 2016
@hannes-ucsc
Copy link
Contributor

I think I fixed this already. What branch are you on?

@adderan
Copy link
Contributor Author

adderan commented Feb 10, 2016

I'm on master, because I use the grow-cluster command. It looks like the problem is still there: https://github.com/BD2KGenomics/cgcloud/blob/master/core/src/cgcloud/core/cluster_commands.py#L296

@hannes-ucsc
Copy link
Contributor

Can you try the scalability-fixes branch? It's in fairly good shape right now, probably better than master.

@hannes-ucsc
Copy link
Contributor

... but I do force push to that branch so don't base any work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants