Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: Container Registry Private Endpoint Deployment #4042

Open
1 task done
nico-stylemans opened this issue Dec 21, 2024 · 3 comments
Open
1 task done
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@nico-stylemans
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/container-registry/registry

(Optional) Module Version

No response

Description

The creation of private endpoints fails when replicatons are enabled, but can be fix by add depends on registry_replications on the module call for registry_privateEndpoints

Code snippet for fix

module registry_privateEndpoints 'br/public:avm/res/network/private-endpoint:0.7.1' = [
for (privateEndpoint, index) in (privateEndpoints ?? []): {
name: '${uniqueString(deployment().name, location)}-registry-PrivateEndpoint-${index}'
scope: resourceGroup(privateEndpoint.?resourceGroupName ?? '')
params: {

.........

}
dependsOn: [
registry_replications
]
}
]

Error message :

{"status":"Failed","error":{"code":"DeploymentFailed","target":"/subscriptions/id/resourceGroups/rg/providers/Microsoft.Resources/deployments/ACRdeploy","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"ResourceDeploymentFailure","target":"/subscriptions/id/resourceGroups/rg/providers/Microsoft.Resources/deployments/54aq4t3xuqte2-registry-PrivateEndpoint-0","message":"The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'.","details":[{"code":"DeploymentFailed","target":"/subscriptions/id/resourceGroups/rg/providers/Microsoft.Resources/deployments/54aq4t3xuqte2-registry-PrivateEndpoint-0","message":"At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-deployment-operations for usage details.","details":[{"code":"ResourceDeploymentFailure","target":"/subscriptions/id/resourceGroups/rg/providers/Microsoft.Network/privateEndpoints/priv-endpoint-acr-weu","message":"The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'.","details":[{"code":"InvalidPrivateEndpointConnectionRequestParameters","message":"Call to Microsoft.ContainerRegistry/registries failed. Error message: The request body for private endpoint connection creation has one or more invalid parameters: remotePrivateEndpoint/connectionDetails: The incoming connection details count does not match the current home registry connection details count. Expected: 3, Received: 2. For more information, please visit https://aka.ms/acr/private-link.","details":[]}]}]}]}]}}

(Optional) Correlation Id
No response

(Optional) Correlation Id

No response

@nico-stylemans nico-stylemans added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Dec 21, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Dec 21, 2024
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Dec 21, 2024
Copy link

@nico-stylemans, thanks for submitting this issue for the avm/res/container-registry/registry module!

Important

A member of the @Azure/avm-res-containerregistry-registry-module-owners-bicep or @Azure/avm-res-containerregistry-registry-module-contributors-bicep team will review it soon!

Warning

Tagging the AVM Core Team (@Azure/avm-core-team-technical-bicep) due to a module owner or contributor having not responded to this issue within 3 business days. The AVM Core Team will attempt to contact the module owners/contributors directly.

Tip

  • To prevent further actions to take effect, the "Status: Response Overdue 🚩" label must be removed, once this issue has been responded to.
  • To avoid this rule being (re)triggered, the ""Needs: Triage 🔍" label must be removed as part of the triage process (when the issue is first responded to)!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Status: Response Overdue 🚩 When an issue/PR has not been responded to for X amount of days Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants