Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] OneDeploy for Flex consumption SKU #40987

Open
weidongxu-microsoft opened this issue Jul 3, 2024 · 2 comments
Open

[FEATURE REQ] OneDeploy for Flex consumption SKU #40987

weidongxu-microsoft opened this issue Jul 3, 2024 · 2 comments
Assignees
@weidongxu-microsoft
Labels
App Services feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. needs-triage This is a new issue that needs to be triaged to the appropriate team.

Comments

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Jul 3, 2024 •
edited
Loading

To support function app deployment on new Flex consumption SKU, there needs to be an update to existing OneDeploy in Java SDK.

  1. Detect if the app is on flex consumption. If cannot detect, then may be add a parameter where user can specify SKU.
  2. If Flex consumption, then
    a. Pass 2 API parameters: RemoteBuild = false and deployer = JavaSDK. API example:
    /api/publish?RemoteBuild=false&deployer=JavaSDK
    b. Skip any other parameters and logic performed for existing SKUs
  3. If not flex consumption, then continue with existing logic.
@weidongxu-microsoft weidongxu-microsoft added Mgmt This issue is related to a management-plane library. App Services feature-request This issue requires a new behavior in the product in order be resolved. labels Jul 3, 2024
@weidongxu-microsoft weidongxu-microsoft changed the title [FEATURE REQ] [FEATURE REQ] OneDeploy for Flex consumption SKU Jul 3, 2024
@github-actions github-actions bot added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Jul 3, 2024
@XiaofeiCao
Copy link
Contributor

Azure CLI implementation from @Flanker32 :
https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/appservice/custom.py#L720

@weidongxu-microsoft
Copy link
Member Author

Thanks Xiaofei. Appears they really don't need the type query param.

@weidongxu-microsoft weidongxu-microsoft self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels
App Services feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library. needs-triage This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weidongxu-microsoft @XiaofeiCao and others