-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ANDROID] android compatible methods in azure core flagged by animal sniffer #36275
Comments
Branch adding custom annotation and demonstration of functionality in Azure core class ReferenceManagerImpl.java Potential workaround for Azure#36275
Thanks for sharing this feedback @jr1000000; @JonathanGiles could you follow up with the folks working on Android support? |
Thanks @jr1000000 for this report. |
Hi @jr1000000. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue. |
added alternate method to suppress all errors caused by a specific class using ignores tag in animal-sniffer maven plugin configuration. commented out both suppression methods until there is a decision about how best to implement this in live. Alternate workaround for issue Azure#36275
Hi @jr1000000, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you! |
Investigating options for demonstrating compatibility in android before suppressing these errors. |
Animal Sniffer identifies java.lang.invoke.MethodHandle.invoke and java.lang.invoke.MethodHandles.Lookup as not compatible with any android or java signatures.
animal-sniffer output on azure-core:
This occurs anytime animal-sniffer:check is run against azure-core.
java.lang.invoke.MethodHandle.invoke is supported under android api level 26 so these signature mismatches should not be flagged.
It is likely a result of issue mojohaus/animal-sniffer#67
The text was updated successfully, but these errors were encountered: