Givermei spring update version to 3.2.7 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, this PR will also undo the code changes done for the messaging lab ... @sonwan2020 |
vermegi
commented
Sep 20, 2024
Comment on lines
+1
to
+3
| CREATE DATABASE IF NOT EXISTS petclinic; | ||
| GRANT ALL PRIVILEGES ON petclinic.* TO pc@localhost IDENTIFIED BY 'pc'; | ||
|
|
There was a problem hiding this comment.
I should probably delete this again, I seem to remember with these lines in place we had issues starting up on Azure MySQL db
vermegi
commented
Sep 20, 2024
Comment on lines
+1
to
+3
| CREATE DATABASE IF NOT EXISTS petclinic; | ||
| GRANT ALL PRIVILEGES ON petclinic.* TO pc@localhost IDENTIFIED BY 'pc'; | ||
|
|
There was a problem hiding this comment.
Same, these we should delete again.
vermegi
commented
Sep 20, 2024
Comment on lines
+1
to
+3
| CREATE DATABASE IF NOT EXISTS petclinic; | ||
| GRANT ALL PRIVILEGES ON petclinic.* TO pc@localhost IDENTIFIED BY 'pc'; | ||
|
|
There was a problem hiding this comment.
This should be deleted
|
@sonwan2020 can you review? Just to know as well if it's ok to override the full existing code. All edits in code will get lost with this PR. |
|
@vermegi I will merge and test this PR lately |
|
some upcoming PRs already upgrade this to 3.3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
fixes #33 and kinda #31
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Run-through the full lab with this new version
What to Check
Verify that the following are valid
Other Information
I did not do a test run yet, this is just a clean copy paste from https://github.com/spring-petclinic/spring-petclinic-microservices/tree/main