Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clobbering files causes duplicate copies and early callback #95

Open
maxg opened this issue May 22, 2015 · 0 comments
Open

Clobbering files causes duplicate copies and early callback #95

maxg opened this issue May 22, 2015 · 0 comments

Comments

@maxg
Copy link

maxg commented May 22, 2015

Duplicate of issue #71 and others. Existing fixes in PRs #77, #88, and others.

A new fix and test are proposed in PR #94.

Duplicate copies: when clobbering an existing file, onFile does both a remove-and-copy (line 94) and possibly copies the file again depending on modified (line 102).

Early callback: both the call to copyFile on line 95 and one of the later calls to copyFile or cb will increment the number of finished callbacks, with the result that the callback passed to ncp is called too early, before the copy is necessarily completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant