-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Issue 17744 fix - DataContext Ancestor Inherited Value Change #17755
base: master
Are you sure you want to change the base?
[WIP] Issue 17744 fix - DataContext Ancestor Inherited Value Change #17755
Conversation
…ntext itself is bound.
Converting this to a draft seeing the various tests failures. This is clearly more complex than I originally thought. |
@[email protected] @ShadowMarker789, Please read the following Contributor License Agreement (CLA). If you agree with the CLA, please reply with the following:
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by AvaloniaUI OÜ and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant AvaloniaUI OÜ, and those who receive the Submission directly b. Patent License. You grant AvaloniaUI OÜ, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to AvaloniaUI OÜ. You agree to notify AvaloniaUI OÜ in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the Republic of Estonia, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and AvaloniaUI OÜ dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. 0 out of 2 committers have signed the CLA. [email protected] doesn't seem to be a GitHub user. |
… bind changes the meaning of the datacontext for other properties.
You can test this PR using the following package version. |
@ShadowMarker789 I would encourage you to start by creating a failing unit test. |
This is a great suggestion, but I am finding it very difficult to do so. So far from investigation, it seems to require multiple different xaml files to manifest, involving compiled-bindings in conjunction with the way they're using a view-model-locator to assign the data-context. For instance, if I take the original poster's example project which manifests the bug, and then transpose the xaml into a single xaml file the bug vanishes. Do you know if there's any sample unit tests I can look at that meets the above criteria for example? It needs to have compiled xaml, compiled-bindings at least. Whereas the unit-tests I've found so far are more like this. (Image below) Which unfortunately passes and does not manifest the bug in question. |
Bugfixing Pull Request
What is the current behavior?
The current behaviour is that changes to an inherited data-context do not properly event changes to this when the data-context is bound locally, such as
{Binding Path=., Mode=OneWay}
Notably, this only occurs when the depth of the tree between owner and ancestor is deep enough to hit
OnAncestorInheritedValueChanged
, that is, not a direct child of the Owner of the property.What is the updated/expected behavior with this PR?
The expected behaviour is that changes to an inherited data-context properly event changes to this when the data-context is bound locally, such as
{Binding Path=., Mode=OneWay}
Notably, this only occurs when the depth of the tree between owner and ancestor is deep enough to hit
OnAncestorInheritedValueChanged
, that is, not a direct child of the Owner of the property.How was the solution implemented (if it's not obvious)?
Additional checks have been made in
ValueStore.cs
to add exceptions for when the property is the DataContext property AND there is a binding on the DataContextChecklist
Should any of these be done for this change?
Breaking changes
Not aware of any.
Obsoletions / Deprecations
None.
Fixed issues
Fixes #17744