Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privately hosted templates are not supported #432

Open
djejaquino opened this issue Jun 2, 2020 · 2 comments
Open

Privately hosted templates are not supported #432

djejaquino opened this issue Jun 2, 2020 · 2 comments
Assignees

Comments

@djejaquino
Copy link

djejaquino commented Jun 2, 2020

🐛 Bug report

Current Behavior

Running a npx @availity/worflow init command with -t or --template parameter, using a privately hosted starter will abort the process.

Expected behavior

To successfully initialize an updated workflow-based project.

Reproducible example

image

Suggested solution(s)

Assume static hostedInfo for https://code.availity.com, to support (at least) Availity-provided repositories.

Additional context

Logger.failed('Could not find Hosted Git Info for the Project.', hostedInfo);

Your environment

  Binaries:
    Node: 8.9.4 - C:\Program Files\IBM\node\node.EXE
    Yarn: 1.22.0 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
    npm: 5.6.0 - C:\Program Files\IBM\node\npm.CMD

EDIT: grammar

@nylon22 nylon22 self-assigned this Oct 7, 2020
@nylon22
Copy link
Member

nylon22 commented Oct 7, 2020

Some background on this. We use a library: https://github.com/npm/hosted-git-info, to get metadata about the git url passed in via the template option before cloning it. You can see that here:

const hostedInfo = hostedGitInfo.fromUrl(templateUrl);
if (hostedInfo) {
await clone(hostedInfo, appPath);
} else {
Logger.failed('Could not find Hosted Git Info for the Project.', hostedInfo);
}

That library does not support https://code.availity.com. I see two paths forward here:

  1. The library does support pull requests for new hosts. We could add this host.
  2. We can remove the dependency on that library and do what it does in-house.

@nylon22
Copy link
Member

nylon22 commented Oct 7, 2020

Related: npm/hosted-git-info#39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants