Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable Numerics fail in validate-data #571

Open
vjeeva opened this issue Sep 26, 2024 · 0 comments
Open

Nullable Numerics fail in validate-data #571

vjeeva opened this issue Sep 26, 2024 · 0 comments

Comments

@vjeeva
Copy link
Contributor

vjeeva commented Sep 26, 2024

Problem:

  • Tables with nullable numeric data types are breaking the validate-data function.
  • If a row has a NaN in Postgres, AsyncPG reads that as Python Object Decimal('NaN').
  • Python also thinks that Decimal('NaN') == Decimal('NaN') -> False.

Solution

vjeeva added a commit that referenced this issue Sep 26, 2024
vjeeva added a commit that referenced this issue Sep 27, 2024
vjeeva added a commit that referenced this issue Sep 27, 2024
* test: added test case addressing #571

* fix: accommodate Decimal NaN != Decimal NaN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant