Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stage edit target updates with refreshSystemLock callbacks #4009

Conversation

jufrantz
Copy link
Contributor

@jufrantz jufrantz commented Nov 22, 2024

On refreshSystemLock, the stage's editTarget could be improperly set to the session layer when our callback unlocks a layers which is non-writable on disk. In such cases, in-memory layer editions should still be allowed without enforcing the session layer. We are encountering this issue in production and we need the editTarget selection to be preserved in such case.

Additionally, the editTarget update did not account for new locks that could be introduced by onRefreshSystemLock callbacks.

Included changes:

  • Changed the timing of updateEditTarget calls within the refreshSystemLock command: jufrantz@33e48e2
  • Added unit tests to validate refreshSystemLock behavior across various callback scenarios: jufrantz@c07344d

@seando-adsk seando-adsk added the workflows Related to in-context workflows label Nov 27, 2024
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 28, 2024
@seando-adsk seando-adsk merged commit 3bce4d1 into Autodesk:dev Nov 28, 2024
11 checks passed
@jufrantz jufrantz deleted the fix_edit_target_with_onRefreshSystemLock_callback branch December 2, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge workflows Related to in-context workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants