Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMSUSD-1771 remove schema from prims #4008

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

pierrebai-adsk
Copy link
Collaborator

Add functions to support schema removal in UsdUfe:

  • Add removeSchemaFromPrim helper function to remove a single-apply schema from a prim.
  • Add removeMultiSchemaFromPrim helper function to remove a single-apply schema from a prim.
  • Expose those functions to Python.
  • Add unit test for the functions.

Remove schema command:

  • Add a -rem (-removeSchema) flag to the schema command.
  • Implement schema removal in the command.
  • Update the documentation about the command.
  • Add unit tests for the removal of schemas via the command.

Remove schema menu items:

  • Add a "Remove Schema" menu item in the "Attributes" menu of the AE.
  • Add each applied schema of the selected prims to the menu.
  • Echo to the user the schema commands invoked by the menu items.

@pierrebai-adsk pierrebai-adsk added ufe-usd Related to UFE-USD plugin in Maya-Usd schema Related to core library schemas labels Nov 21, 2024
@pierrebai-adsk pierrebai-adsk self-assigned this Nov 21, 2024
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor comment about string.

@pierrebai-adsk pierrebai-adsk removed their assignment Nov 26, 2024
Add functions to support schema removal in UsdUfe:
- Add removeSchemaFromPrim helper function to remove a single-apply schema from a prim.
- Add removeMultiSchemaFromPrim helper function to remove a single-apply schema from a prim.
- Expose those functions to Python.
- Add unit test for the functions.

Remove schema command:
- Add a -rem (-removeSchema) flag to the schema command.
- Implement schema removal in the command.
- Update the documentation about the command.
- Add unit tests for the removal of schemas via the command.

Remove schema menu items:
- Add a "Remove Schema" menu item in the "Attributes" menu of the AE.
- Add each applied schema of the selected prims to the menu.
- Echo to the user the schema commands invoked by the menu items.

Fix typo and use resources for text.
@pierrebai-adsk pierrebai-adsk force-pushed the bailp/EMSUSD-1771/remove-schema-from-prims branch from 71d2aa1 to 81b1dce Compare November 26, 2024 17:13
@pierrebai-adsk pierrebai-adsk self-assigned this Nov 26, 2024
@pierrebai-adsk pierrebai-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 26, 2024
@seando-adsk seando-adsk merged commit cd8f906 into dev Nov 26, 2024
11 checks passed
@seando-adsk seando-adsk deleted the bailp/EMSUSD-1771/remove-schema-from-prims branch November 26, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge schema Related to core library schemas ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants