EMSUSD-1625 - Certain USD light shapes disappear if user try to edit as maya data. #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-1625/light_edit_as_maya
branch
from
ab0db30 to
90845c1
Compare
samuelliu-adsk
commented
Nov 20, 2024
| return; | ||
| } | ||
|
|
||
| if (lightShape == 1) { |
There was a problem hiding this comment.
Note sure if we use an enum than the number 1 is better. It is an arbitrary number either way...
samuelliu-adsk
commented
Nov 20, 2024
| @@ -222,4 +223,114 @@ void PxrUsdTranslators_AreaLightWriter::Write(const UsdTimeCode& usdTime) | |||
| usdTime, primSchema, lightFn, _GetSparseValueWriter()); | |||
| } | |||
|
|
|||
| #ifdef UFE_VOLUME_LIGHTS_SUPPORT | |||
| PXRUSDMAYA_REGISTER_WRITER(volumeLight, PxrUsdTranslators_VolumeLightWriter); | |||
There was a problem hiding this comment.
One major problem I was struggling is here. As shown on L179, we should register a schema here but one Maya light type can only map to one usd type. Here there will be three possible schemas to register for volumeLight so I didn't register at the time. After playing around I dont see a major issue caused by this but I think we better address this.
AramAzhari-adsk
requested changes
Nov 21, 2024
There was a problem hiding this comment.
As discussed, please check that:
- Each of the recently added lights gizmos actually shade similarly when they are a USD light and when they are being edited as a Maya light.
- If any of them do not have a matching light shading, please block / remove the option of being able to Edit As Maya for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.