EMSUSD-550 - Control the Types of Objects to Export #3338
Conversation
| self._ValidateLight() | ||
| self._ValidateCamera() | ||
| self._ValidateMeshCamera() | ||
| self._ValidateMeshLight() |
There was a problem hiding this comment.
No need to test the case of export all three, that is already covered by other unit tests
samuelliu-adsk
force-pushed
the
samuelliu-adsk/EMSUSD-550/export_types
branch
from
566dbc0 to
455f5ae
Compare
seando-adsk
requested review from
pierrebai-adsk
and removed request for
seando-adsk
| @@ -385,6 +385,39 @@ bool UsdMayaWriteJobContext::_NeedToTraverse(const MDagPath& curDag) const | |||
| // If we're not going to create a prim at curDag, then we do not need to | |||
| // traverse. | |||
| return false; | |||
| } else { | |||
There was a problem hiding this comment.
Given the if returns, I'd not put the extra check in an else to avoid nesting. Other previous checks are not nested inside elses.
| MStatus status; | ||
| MObject obj = shapeDagPath.node(); | ||
| const MFnDependencyNode depFn(obj, &status); | ||
| if (!status) { |
There was a problem hiding this comment.
IDK if failure to cerate a MFnDependencyNode should be treated as failure. A node not being a MFnDependencyNode is not an error, it just that the node does not support the API.
It should just skip the type check.
|
|
||
| const std::string mayaTypeName(depFn.typeName().asChar()); | ||
|
|
||
| if (mArgs.excludeExportTypes.count(TfToken("Meshes")) != 0) { |
There was a problem hiding this comment.
Were the name of types part of the design? I ask because I find that using "Meshes" instead of "mesh" for a type name feels wrong. The type should not be plural.
In any cases, the string comparison should be case-insensitive.
There was a problem hiding this comment.
Yea so I used "Meshes" to keep it consistent with the UX design. It designed to use "Meshes" and "Cameras" etc. But yea I can make it case-insensitive
|
|
||
| if (stringArrayContains("geometry", $sectionNames)) { | ||
| $excludeExportTypes = mayaUsdTranslatorExport_SetSuboptionsFromCheckBox($excludeExportTypes, "", "Meshes", "exportMeshesCheckBox"); |
There was a problem hiding this comment.
The flag is passed explicitly here, so changing from "Meshes" to "mesh" seem feasible without modifying UI shown to teh user.
There was a problem hiding this comment.
I don't know if that will confuse the user.. Like they see "Meshes" in the UI but when use it in command it changes to "mesh". They won't know it unless they read extra documents to get that information...
There was a problem hiding this comment.
But yea its definitely feasible
| @@ -406,15 +404,18 @@ bool UsdMayaWriteJobContext::_NeedToTraverse(const MDagPath& curDag) const | |||
|
|
|||
| const std::string mayaTypeName(depFn.typeName().asChar()); | |||
|
|
|||
| if (mArgs.excludeExportTypes.count(TfToken("Meshes")) != 0) { | |||
| if ((mArgs.excludeExportTypes.count(TfToken("Meshes")) != 0) | |||
| || (mArgs.excludeExportTypes.count(TfToken("meshes")) != 0)) { | |||
There was a problem hiding this comment.
I think it would be cleaner and more general to lowercase both strings and compare those.
samuelliu-adsk
added
adsk
samuelliu-adsk
added
the
ready-for-merge
| @@ -0,0 +1,123 @@ | |||
| #!/usr/bin/env mayapy | |||
| # | |||
| # Copyright 2016 Pixar | |||
There was a problem hiding this comment.
New file by you should be Copyright by Autodesk and have current year.
seando-adsk
removed
adsk
samuelliu-adsk
added
the
ready-for-merge
No description provided.