Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFTView() backgroundColor variable not working correctly. #78

Open
rosspaterson001 opened this issue Jan 19, 2024 · 0 comments
Open

FFTView() backgroundColor variable not working correctly. #78

rosspaterson001 opened this issue Jan 19, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rosspaterson001
Copy link

macOS Version(s) Used to Build

macOS 13 Ventura

Xcode Version(s)

Xcode 14

Description

Hi, pretty new to all this (using for a uni project) but pretty sure I have identified an error in the FFTView struct.

In FFTView.swift navigate to the body view, and there is an if statement:
if let amplitude = fft.amplitudes[$0]{
In the amplitude bar call in the if function(line 143), I believe it should pass:
backgroundColor: backgroundColor)

It passes it in the else statement so it should be passed in the if statement too, correct?

I would fork and stuff, but this is my first time properly using version control and I don't want to mess with stuff and delete my code before I know what I'm doing, sorry!

Crash Logs, Screenshots or Other Attachments (if applicable)

With original code:
Screenshot 2024-01-19 at 15 02 35

With amended code:
Screenshot 2024-01-19 at 15 01 48

@rosspaterson001 rosspaterson001 added the bug Something isn't working label Jan 19, 2024
NickCulbertson added a commit that referenced this issue Jan 19, 2024
Fix bar mask color not matching background color in FFTView. Mentioned in #78
aure pushed a commit that referenced this issue Mar 8, 2024
Fix bar mask color not matching background color in FFTView. Mentioned in #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant