-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate correct Minimum Supported Rust Version (MSRV) #159
Comments
That crates.io MSRV number is fake. crates.io just pretends that the MSRV is 1.56.0 because the crate has edition 2021 and 1.56.0 is when that edition was introduced. I've filed rust-lang/crates.io#10103 on them to not show fake values.
The build.rs change is just the first thing that won't compile on 1.56.0. Various things from libstd are also used that won't. I only test for compilation with latest stable and nightly, because the main user of my crate that I know about is my dayjob, and they keep up with Rust stable releases too.
Sure, so then what version are you using that you want to work? |
Thanks for explaining the point of getting a derived MSRV version based on the Rust edition. I can stay with an older version of this crate until I can update the Rust versions in the project, so this is not a problem for me. The issue was open in case you wanted to support MSRV correctly. |
If that was the case I would not have asked you what version you want supported. |
The crate in version 0.23 is released with MSRV of 1.56, but a compilation with Rust lower than 1.77 fails.
To be consistent I recommend to either use the old directive as indicated by the compiler or to clearly state MSRV of Rust 1.77.
Background: for some embedded applications we cannot always use the latest compiler versions.
The text was updated successfully, but these errors were encountered: