withdraw_auto_from_l1 escrow is not zeroed

[ptisserand]

From https://codehawks.cyfrin.io/c/2024-07-ark-project/s/177

L2 escrow is not reset when withdrawn.

details

When tokens are deposited on L2 via deposit_tokens(), they will be deposited in the escrow mapping, so when someone transfers back the same NFTs from L1 → L2 to take it from the contract balance, because they already exist.

But when they are transferred back to L2, withdraw_auto_from_l1() transfers them if they exist in the escrow mapping, but never resets the mapping when transferring it, this creates confusion that the tokens are still in the bridge.cairo contract.

Unit test must be provided.

[od-hunter]

Hi @ptisserand , please can I be assigned this when od hack starts?

To solve this issue, I'd take the following steps:

1. I'll update withdraw_auto_from_l1() (add logic to reset the escrow mapping after tokens are transferred, ensuring they are no longer recorded in the contract's state).
2. I'll test that after depositing tokens, withdrawing them using withdraw_auto_from_l1() resets the escrow.
   Validate the escrow mapping is cleared after the withdrawal.
3. I'll ensure tests cover multiple scenarios to confirm the escrow is correctly reset in all cases.

Please assign me.

[mubarak23]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I am a Experience Cairo smart contract developer with experience working on projects such as Just Art Peace, Dojo, Kart, TBA, and Shinigami. Before transitioning to Cairo development, I was a backend developer specializing in Rust.

My recent work with cairo starknet

• check for coinbase maturity keep-starknet-strange/raito#128
• validate relative lock time on input of transaction keep-starknet-strange/raito#143
• lock and is_lock function of lockable component horuslabsio/TBA#45
• feat: _asReferencePubParams check horuslabsio/karst-core#60
• Ft nft mint quest keep-starknet-strange/art-peace#121
• feat: nullifier_registry contract functions keep-starknet-strange/zkramp#33
• Ft username store contract keep-starknet-strange/art-peace#32
• Account v3 test coverage horuslabsio/TBA#53

My recent work with rust

• https://github.com/mubarak23/axum-user-auth
• remove debug info from emitting antoyo/rustc_codegen_gcc#1
• Remove pass test antoyo/rustc_codegen_gcc#5
• feat(balance): add inbound lightning liquidity to GetBalancesResponse fedimint/fedimint#5994
• https://github.com/mubarak23/soroban-bank

How I plan on tackling this issue

As issue describe

• reset the mapping after withdrawal is handle
• test the case of making sure mapping is reset after withdrawal
• test edge cases

ETH: 15HRS

[od-hunter]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Please can I be assigned this issue? This is my first time applying in this ecosystem and I’d love to be given the opportunity. I am a blockchain Developer, and my experience includes html, css, react, JavaScript,TypeScript and solidity, python and Cairo.

How I plan on tackling this issue

To solve this issue, I'd take the following steps:

1.⁠ ⁠I’ll update withdraw_auto_from_l1() (add logic to reset the escrow mapping after tokens are transferred, ensuring they are no longer recorded in the contract's state).
2.⁠ ⁠I’ll test that after depositing tokens, withdrawing them using withdraw_auto_from_l1() resets the escrow.
Validate the escrow mapping is cleared after the withdrawal.
3.⁠ ⁠I’ll ensure tests cover multiple scenarios to confirm the escrow is correctly reset in all cases.

Please assign me.

[onlydustapp]

The maintainer ptisserand has assigned od-hunter to this issue via OnlyDust Platform.
Good luck!

[od-hunter]

The maintainer ptisserand has assigned od-hunter to this issue via OnlyDust Platform. Good luck!

Thank you ser🫡

[ptisserand]

Hi @od-hunter any update on this ?

[od-hunter]

Hi @od-hunter any update on this ?

I’ve started working on it. Will push a pr soon