Community App Store (Sourcery refactored) #144
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| for line in map(str.strip, f): | ||
| if not line.startswith("#") and not line.startswith("git+"): | ||
| requirements.append(line) | ||
| requirements.extend( | ||
| line | ||
| for line in map(str.strip, f) | ||
| if not line.startswith("#") and not line.startswith("git+") | ||
| ) | ||
|
|
There was a problem hiding this comment.
Lines 39-41 refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
| @@ -5,6 +5,7 @@ | |||
| https://docs.djangoproject.com/en/dev/ref/settings/ | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
Lines 430-435 refactored with the following changes:
- Merge consecutive list appends into a single extend (
merge-list-appends-into-extend)
This removes the following comments ( why? ):
# Performance analysis tools
# API docs generator
| if default_tab: | ||
| return default_tab | ||
|
|
||
| for tabs in tab_groups: | ||
| if tabs: | ||
| return tabs[0] | ||
|
|
||
| return None | ||
| return default_tab or next((tabs[0] for tabs in tab_groups if tabs), None) |
There was a problem hiding this comment.
Function _default_tab refactored with the following changes:
- Simplify if expression by using or (
or-if-exp-identity) - Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Use the built-in function
nextinstead of a for-loop (use-next)
| for item in search_list: | ||
| if item.__contains__(key) and item[key] == value: | ||
| return item if return_item else True | ||
| return False | ||
| return next( | ||
| ( | ||
| item if return_item else True | ||
| for item in search_list | ||
| if item.__contains__(key) and item[key] == value | ||
| ), | ||
| False, | ||
| ) |
There was a problem hiding this comment.
Function is_key_value_in_iter refactored with the following changes:
- Use the built-in function
nextinstead of a for-loop (use-next)
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.86%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
Pull Request #69 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
app_storebranch, then run:Help us improve this pull request!