Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community App Store (Sourcery refactored) #141

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Feb 4, 2022

Pull Request #69 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the app_store branch, then run:

git fetch origin sourcery/app_store
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from Archmonger February 4, 2022 09:41
@sourcery-ai sourcery-ai bot force-pushed the sourcery/app_store branch from 448e3de to ad10e86 Compare February 4, 2022 09:43
@@ -4,6 +4,7 @@
For the full list of settings and their values, see
https://docs.djangoproject.com/en/dev/ref/settings/
"""

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 123-384 refactored with the following changes:

@@ -1,4 +1,5 @@
""" Settings required by django-app. """

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 32-32 refactored with the following changes:

ENV_PREFIX = ENV_PREFIX + "_"
ENV_PREFIX = f'{ENV_PREFIX}_'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 16-16 refactored with the following changes:

base_url = "/" + base_url
base_url = f'/{base_url}'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_base_url refactored with the following changes:

home_url = "/" + home_url
home_url = f'/{home_url}'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_home_url refactored with the following changes:

self.success_url = self.request.path + f"?{params.urlencode()}"
self.success_url = f'{self.request.path}?{params.urlencode()}'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function SuccessCurrentUrlMixin.get_success_url refactored with the following changes:

__name__ + ": This is a stub for a view that has not yet been defined."
f'{__name__}: This is a stub for a view that has not yet been defined.'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function stub refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Feb 4, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 16.45 🙂 16.45 🙂 0.00
Method Length 118.33 🙂 118.33 🙂 0.00
Working memory 22.32 ⛔ 22.32 ⛔ 0.00
Quality 41.07% 😞 41.07% 😞 0.00%
Other metrics Before After Change
Lines 588 589 1
Changed files Quality Before Quality After Quality Change
conreq/settings.py 12.63% ⛔ 12.63% ⛔ 0.00%
conreq/utils/environment.py 80.88% ⭐ 80.88% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
conreq/utils/environment.py set_env 5 ⭐ 66 🙂 10 😞 69.01% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Archmonger Archmonger merged commit 25ad488 into app_store Feb 4, 2022
@Archmonger Archmonger deleted the sourcery/app_store branch February 4, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant