Community App Store (Sourcery refactored)

[sourcery-ai]

Pull Request #69 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the app_store branch, then run:

git fetch origin sourcery/app_store
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Function is_key_value_in_list refactored with the following changes:

• Swap positions of nested conditionals (swap-nested-ifs)
• Lift code into else after jump in control flow (reintroduce-else)
• Hoist repeated code outside conditional statement (hoist-statement-from-if)
• Replace if statement with if expression (assign-if-exp)

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.10%.

Quality metrics	Before	After	Change
Complexity	4.43 ⭐	4.03 ⭐	-0.40 👍
Method Length	18.30 ⭐	18.20 ⭐	-0.10 👍
Working memory	6.34 🙂	6.55 🙂	0.21 👎
Quality	82.57% ⭐	82.47% ⭐	-0.10% 👎

Other metrics	Before	After	Change
Lines	53	51	-2

Changed files	Quality Before	Quality After	Quality Change
conreq/utils/generic.py	82.57% ⭐	82.47% ⭐	-0.10% 👎

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
conreq/utils/generic.py	clean_string	5 ⭐	67 🙂	10 😞	68.85% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!