Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ZLib to compress PNG and VTU file output #35

Open
markstock opened this issue Jul 31, 2020 · 1 comment
Open

Use ZLib to compress PNG and VTU file output #35

markstock opened this issue Jul 31, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@markstock
Copy link
Collaborator

XML-based VTK files can use one of three compression algorithms for data arrays (LZ4, ZLib, LZMA), and PNG writing can use only ZLib. We should support zlib compression for png and vtu file output. Hopefully Paraview can read compressed files - I recall it failing to read any file with "appended" data.

Since zlib is relatively small, we should consider copying a header-only, compliant-licensed library into our repository. Consider zstr, miniz, or gzip-hpp.

Also, since Vtk output needs not only an encoding library but a compression library, maybe we should make it it's own cpp file (to generate a .o file), and not as a pure header - this will save compilation time.

@markstock markstock added the enhancement New feature or request label Jul 31, 2020
@BHill96
Copy link
Contributor

BHill96 commented Aug 11, 2020

The png compression was added by pull request #39. The VTU compression is tricky and will be put on the back-burner for now. The current attempts are stored on the compression branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants