Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify KDE about changed icons using dbus #123

Closed
probonopd opened this issue May 30, 2019 · 6 comments
Closed

Notify KDE about changed icons using dbus #123

probonopd opened this issue May 30, 2019 · 6 comments

Comments

@probonopd
Copy link
Member

probonopd commented May 30, 2019

https://github.com/TheAssassin/AppImageLauncher/blob/9aedcf2cb308c6362bc7eed2b0ba88d388bb2079/src/shared/shared.cpp#L580-L585

When implemented in libappimage, this should not be done using Qt, though. Unless we switch libappimage to Qt.

Reference:
TheAssassin/AppImageLauncher#165

@azubieta
Copy link
Contributor

Already investigated this and found that there are no dbus services listening to that signal. Please check the details here AppImageCommunity/appimaged#88 (comment)

@azubieta
Copy link
Contributor

azubieta commented Jun 4, 2019

Right now we don't call any desktop update from libappimage, first we need to check if we want to do it. Second we should move all the known hacks (not only kde) to libappimage

@probonopd
Copy link
Member Author

Yes. @TheAssassin wdyt?

@azubieta
Copy link
Contributor

azubieta commented Jun 4, 2019

Already investigated this issue and the dbus call has no effect so far.
This also seems to be a duplicated of #29
Will close the issue and the discussions about moving desktop update hacks could continue on #129
Please feel free to reopen it if required.

@azubieta azubieta closed this as completed Jun 4, 2019
@probonopd
Copy link
Member Author

the dbus call has no effect so far

@TheAssassin why are you using it in AppImageLauncher?

@TheAssassin
Copy link
Member

I was told this might help in some chat, IIRC. It certainly can't hurt, I'm using Qt anyway, so DBus is easy to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants