Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Appearance of Delete option in side menu #5668

Open
MayurSMahajan opened this issue Jul 1, 2024 · 1 comment
Open

[Bug] Appearance of Delete option in side menu #5668

MayurSMahajan opened this issue Jul 1, 2024 · 1 comment
Labels
good first issue for devs for the community members to claim side panel

Comments

@MayurSMahajan
Copy link
Collaborator

Bug Description

There are two issues with the Delete option in the current Side Menu:

  1. The icon of the bin and text delete are not aligned properly.
  2. The colour red for the icon and the text can cause poor contrast.

Now the second point is really a personal preference. But I think coloured text is never good UI/UX practice.

How to Reproduce

  1. In the side menu, click on any item/page
  2. Click on three dots of the page
  3. Observe a menu of options open up as shown in the screenshot.
  4. Observe the alignment of delete option and the colour of it.

Expected Behavior

The delete icon of bin and the text should be centre aligned
The colour should be changed to normal text colour (If the team wants to keep it the way it is, that is fine too.)

Operating System

Sonoma 14.5

AppFlowy Version(s)

0.6.1

Screenshots

Screenshot 2024-07-01 at 5 00 43 PM

Additional Context

No response

@MayurSMahajan MayurSMahajan added good first issue for devs for the community members to claim side panel labels Jul 1, 2024
@MayurSMahajan
Copy link
Collaborator Author

cc @annieappflowy does the team want the delete option in red colour or plain text colour? That's a subjective decision. Please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue for devs for the community members to claim side panel
Projects
None yet
Development

No branches or pull requests

1 participant