This project is work of many contributors.
You're encouraged to submit pull requests, propose features and discuss issues.
In the examples below, substitute your Github username for contributor in URLs.
Fork the project on Github and check out your copy.
git clone https://github.com/Antondomashnev/FBSnapshotsViewer.git
cd FBSnapshotsViewer
git remote add upstream https://github.com/Antondomashnev/FBSnapshotsViewer.git
Install Bundler if you have not previously done so on your development machine.
gem install bundler
Ensure that you can build the project and run tests.
bundle install
bundle exec pod install
bundle exec fastlane mac test
Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.
git checkout master
git pull upstream master
git checkout -b my-feature-branch
Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build. Add tests to FBSnapshotsViewerTests.
We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.
Implement your feature or bug fix.
Swift style is enforced with SwiftLint. The check is done on every compile via run phase. You can check the configuration here.
Make sure that bundle exec fastlane osx build_app completes without errors.
Document any external behavior in the README.
Add a line to CHANGELOG under Next Release. Don't remove Your contribution here.
Make it look like every other line, including a link to the issue being fixed, your name and link to your Github account.
Make sure git knows your name and email address:
git config --global user.name "Your Name"
git config --global user.email "[email protected]"
Writing good commit logs is important. A commit log should describe what changed and why.
git add ...
git commit
git push origin my-feature-branch
Go to https://github.com/contributor/FBSnapshotsViewer and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.
Update the CHANGELOG with the pull request number. A typical entry looks as follows.
* [#42](https://github.com/Antondomashnev/FBSnapshotsViewer/pull/42): Add action to open images in preview - [@contributor](https://github.com/contributor).
Amend your previous commit and force push the changes.
git commit --amend
git push origin my-feature-branch -f
If you've been working on a change for a while, rebase with upstream/master.
git fetch upstream
git rebase upstream/master
git push origin my-feature-branch -f
Go back to your pull request after a few minutes and see whether it passed master with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!
Please do know that we really appreciate and value your time and work. We love you, really.