New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement request: disable when there's no network connection #18

Open

micalevisk opened this issue Sep 30, 2021 · 0 comments

micalevisk commented Sep 30, 2021 •

edited

Loading

Pretty much as is doing here: https://github.com/sindresorhus/notifier-for-github/blob/f1facf697f07bc01a030da358c953e4df0155127/source/background.js#L120

Instead of always running the update function, I think it would be nice to check if navigator.onLine

firefox-github-notifier/background.js

Lines 5 to 6 in aef4672

    
           async function update() { 
        
               let options,

just add the following on above ~~if (!navigator.onLine) return; I guess~~.

The text was updated successfully, but these errors were encountered:

micalevisk mentioned this issue

Do nothing if there's no network connection #19

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment