Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API calls fail better #46

Closed
Tracked by #47
rdohms opened this issue Dec 14, 2013 · 5 comments
Closed
Tracked by #47

Make API calls fail better #46

rdohms opened this issue Dec 14, 2013 · 5 comments

Comments

@rdohms
Copy link
Member

rdohms commented Dec 14, 2013

API calls that require an admin key should fail more gracefully.

@pascaldevink
Copy link
Member

Can't this be fixed in the \DMS\Service\Meetup\AbstractMeetupClient?
Or should it really be fixed with a try/catch in `AmsterdamPHP\Bundle\MeetupBundle\Service\EventService->getEventAttendance()`` for example?
Because than it would be nice if we have a list of calls that require admin permission so it's more clear what needs to be done.

@rdohms
Copy link
Member Author

rdohms commented Oct 8, 2014

Not 100% sure where its best to handle this.
We need to check the calls and the problems and see how the API responds. I can add it to the api wrapper to at least make sure we have proper exceptions to handle.

@rob-erwt
Copy link
Contributor

This issue is bugging me right now, so I'll try and fix it :P

@pascaldevink
Copy link
Member

This should be right up @ramondelafuente's alley! Now only #45 has to be done to completely satisfy him 😜

pascaldevink pushed a commit that referenced this issue Nov 22, 2014
@pascaldevink
Copy link
Member

Fixed in #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants