Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed App crashes when trying to change radius on avatar #2119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed App crashes when trying to change radius on avatar #2119

wants to merge 1 commit into from

Conversation

kiranraj20
Copy link

fixed #2109
The value is not present if you click on the same element so the function ".toString()" throws an error as the values are not present.
The simple solution is to check whether the value is present or not and the function should be called only when the value is present.

@DemaPy
Copy link
Contributor

DemaPy commented Dec 10, 2024

Problem lies in handler, this is one duplicated actually.
See here: #1978

@DemaPy
Copy link
Contributor

DemaPy commented Dec 10, 2024

@googleknight corrected it already and waiting for approval.

  const onBorderRadiusChange = (value: string) => {
    if (!value) return;
    setValue("basics.picture.borderRadius", stringToBorderRadiusMap[value as BorderRadius]);
  };

@DemaPy DemaPy mentioned this pull request Dec 13, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] App crashes when trying to change radius on avatar
2 participants
@kiranraj20 @DemaPy