Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Let RR download files on its own and then send it to requester instead of a simple redirection #1923

Open
1 task done
xsolinsx opened this issue May 29, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version

Comments

@xsolinsx
Copy link

Is there an existing issue for this feature?

  • Yes, I have searched the existing issues and it doesn't exist.

Feature Description

I would like to keep the minio server private, so only accessible internally through the docker network.
Reactive resume should then be able to download on its own whatever file saved on minio (in my case using the local network with STORAGE_URL=http://minio/reactive-resume) and upload it then to the requester instead of simply redirecting to the STORAGE_URL (which right now must be reachable from the browser)

@xsolinsx xsolinsx added enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version labels May 29, 2024
@AmruthPillai
Copy link
Owner

But then, when you upload a picture on your resume, this has to be accessible via a public URL for the chrome browser on the server to load the image and place it onto the document, and it also has to be visible if the resume is made public so that anyone can visit a URL to view the resume (generating a signed link to access the image every time an anonymous user loads a resume would be too much load on the server).

@xsolinsx
Copy link
Author

xsolinsx commented May 29, 2024

the chrome browser on the server would still have access to the minio local server since it would have to be on the same network or reachable anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Issues that need to be triaged v4 Issues related to the latest version
Projects
None yet
Development

No branches or pull requests

2 participants