Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option in points_to_h3 to define field containing score #87

Open
danbjoseph opened this issue Oct 25, 2024 · 4 comments · May be fixed by #90
Open

add option in points_to_h3 to define field containing score #87

danbjoseph opened this issue Oct 25, 2024 · 4 comments · May be fixed by #90
Assignees

Comments

@danbjoseph
Copy link
Member

now that we have more than one method for scoring (PIXELS and SEGMENTATION) the column with the score is not always gvi_score - allow the user to define what column to use.
@ioalexei maybe you want to take this on?

@ioalexei
Copy link
Contributor

Sure thing - I'll look into it

@ioalexei ioalexei self-assigned this Oct 29, 2024
@ioalexei
Copy link
Contributor

started looking into this but the h3pandas package is throwing an error for me. I've logged an issue on the library - depending how long it takes to get a response, I might need to refactor slightly to remove the h3pandas dependency and reimplement using base h3. (If I need to do that I'll create a separate issue on here.)

@ioalexei
Copy link
Contributor

ioalexei commented Dec 2, 2024

DahnJ/H3-Pandas#33

h3 api has changed between v3 and v4, and h3pandas hasn't taken account of this yet.

  • added h3 <4 as a dependency to pyproject.toml which fixes this until a proper fix is implemented in h3pandas

@ioalexei
Copy link
Contributor

ioalexei commented Dec 2, 2024

Summary of PR:

  • Added argument to specify score field in points_to_h3
    • pixel_counting_gvi score was being read as string - unsure which step this is introduced in but I've added a check for the specified score field that tries to convert it to numeric and returns an error if it can't.
  • Added argument to specify score field in create_webmap
  • Updated Readme to reflect new command options for points_to_h3 and create_webmap
  • Adds pinned dependency for h3 <4, which is a dependency of h3pandas (v4 of h3 instroduces breaking changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants