You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's kinda hard to reproduce. We faced the issue running our e2e tests with multiple threads.
Basically we launch an express server with the middleware.
The e2e campaign shoots multiple POST requests at the same time (due to multiple threads).
Current result
Some requests get the post params from other requests. This is due to post params being saved in a global object here.
See here: let previousPostParams = {};
The next Content-Type: text/html request which arrives on the express server will have data-post attribute in the body tag populated with the post params.
Expected result
Refactor the middleware to not be subject to race conditions.
Additional comments
No response
The text was updated successfully, but these errors were encountered:
Package name
dynamic-content
Package version
11.3.0-rc.8
Reproduction steps
It's kinda hard to reproduce. We faced the issue running our e2e tests with multiple threads.
Basically we launch an express server with the middleware.
The e2e campaign shoots multiple POST requests at the same time (due to multiple threads).
Current result
Some requests get the post params from other requests. This is due to post params being saved in a global object here.
See here: let previousPostParams = {};
The next
Content-Type: text/html
request which arrives on the express server will havedata-post
attribute in the body tag populated with the post params.Expected result
Refactor the middleware to not be subject to race conditions.
Additional comments
No response
The text was updated successfully, but these errors were encountered: