Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaskinportenClient implementation cannot use HybridCache because it is currently in preview #714

Closed
danielskovli opened this issue Jul 10, 2024 · 1 comment · Fixed by #669
Closed

MaskinportenClient implementation cannot use HybridCache because it is currently in preview #714

danielskovli opened this issue Jul 10, 2024 · 1 comment · Fixed by #669
Assignees
@danielskovli
Labels
feature Label Pull requests with new features. Used when generation releasenotes

Comments

@danielskovli
Copy link
Contributor

danielskovli commented Jul 10, 2024 •
edited
Loading

Description

Nuget is refusing to release a stable version of Altinn.App.* because the new Maskinporten implementation uses a package which is currently only available as a preview release.

Status

The current implementation has been reverted from main, because it prevented a scheduled nuget release. This code on this branch is feature-complete, but suffers from the issue described above.

Proposed resolution

Either rewrite the implementation or hold off release until this HybridCache is available as a stable release, which will be when .NET 9.0 is released later this year. At which point the package should be stable, or we could upgrade the framework to get the functionality without an additional dependency.

Related PR

Related issues

This new issue will serve as the new tracking for this feature. The old issue has been closed, and may as well stay closed.
@danielskovli danielskovli linked a pull request Jul 10, 2024 that will close this issue
Implement IMaskinportenClient interface #669
Merged
5 tasks
@danielskovli danielskovli added feature Label Pull requests with new features. Used when generation releasenotes and removed status/triage labels Jul 10, 2024
@danielskovli danielskovli mentioned this issue Jul 10, 2024
Open
4 tasks
@danielskovli danielskovli self-assigned this Jul 10, 2024
@danielskovli danielskovli mentioned this issue Jul 10, 2024
Merged
5 tasks
@danielskovli danielskovli changed the title MaskinportenClient implementation cannot use HybridCache because its a preview release MaskinportenClient implementation cannot use HybridCache because it is currently in preview Jul 10, 2024
@danielskovli
Copy link
Contributor Author

Implementated by locking HybridCache version and disabling warning for NU5104:

<PackageReference Include="Microsoft.Extensions.Caching.Hybrid" Version="[9.0.0-preview.6.24328.4]" NoWarn="NU5104" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielskovli danielskovli

Labels
feature Label Pull requests with new features. Used when generation releasenotes
Projects
Team Apps
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement IMaskinportenClient interface Altinn/app-lib-dotnet
1 participant
@danielskovli