Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate updated app-development intro course #1711

Closed
3 tasks done
nkylstad opened this issue Jul 2, 2024 · 4 comments · Fixed by #1719
Closed
3 tasks done

Translate updated app-development intro course #1711

nkylstad opened this issue Jul 2, 2024 · 4 comments · Fixed by #1719

Comments

@nkylstad
Copy link
Member

nkylstad commented Jul 2, 2024

Description

The updated intro course for app development has an introduction, case description and 5 course modules. Modules 3-5 are not translated to english.

Additional Information

No response

Tasks

Translate:

Tasks

Acceptance Criterias

All course modules are translated to english.

@ErlingHauan
Copy link
Contributor

ErlingHauan commented Aug 12, 2024

Due to simultanous changes made by others, the module order got mixed up. This is fixed in PR #1736.

@nkylstad nkylstad self-assigned this Aug 13, 2024
@nkylstad
Copy link
Member Author

Great job! A few observations during test/readthough:

  • In Norwegian, the module titles are prefixed by "Module ", this is not the case for the english translation.
  • The order was still mixed up for codelist-module in english translation.

Created a little PR to fix this, want to have a look @ErlingHauan? 😊

@ErlingHauan
Copy link
Contributor

ErlingHauan commented Aug 13, 2024

Great job! A few observations during test/readthough:

  • In Norwegian, the module titles are prefixed by "Module ", this is not the case for the english translation.
  • The order was still mixed up for codelist-module in english translation.

Created a little PR to fix this, want to have a look @ErlingHauan? 😊

Thanks @nkylstad!

I see that we almost made identical PRs 😅
The only difference is that I removed the word "the" from the titles, in order to save some space in the navigation. Which do you think we should merge?

@nkylstad
Copy link
Member Author

Hah yep, since this issue was closed I thought your PR had been merged! My bad 😅
Let's go ahead and merge your PR, I will close mine.

@nkylstad nkylstad removed their assignment Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants