Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ISI and ephys to id_types #780

Open
dougollerenshaw opened this issue Aug 9, 2021 · 4 comments
Open

add ISI and ephys to id_types #780

dougollerenshaw opened this issue Aug 9, 2021 · 4 comments
Assignees

Comments

@dougollerenshaw
Copy link
Contributor

the data_access.from_lims.get_id_type function does not find IDs for ISI sessions. We should add ISI sessions and potentially extracellular ephys sessions.

@DowntonCrabby
Copy link
Collaborator

I have a branch I'm working on (preconditions_dev) where I refactored the get_id_type function so that it can now get

ophys_experiment_id
ophys_session_id
behavior_session_id
specimen_id
donor_id
cell_roi_id
cell_specimen_id
ophys_container_id
supercontainer_id

I can very easily add the isi and extracellular ephys sessions to that list as well

@dougollerenshaw
Copy link
Contributor Author

@DowntonCrabby sounds good. What's your timeline for making a PR to get that merged? @seanmcculloch was having an issue with mouseseeks that would be resolved if this issue were resolved, so I figured he could implement this small fix pretty quickly to get himself unstuck.

@DowntonCrabby
Copy link
Collaborator

My timeline is probably end of week. If @seanmcculloch needs it sooner I can send him the individual functions (there are 3) to implement.

@seanmcculloch
Copy link
Collaborator

That sounds fine @DowntonCrabby Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants