Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visual_behavior.data_access.loading.get_sdk_segmentation_mask_image looks to be buggy... #664

Open
njmei opened this issue Aug 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@njmei
Copy link
Collaborator

njmei commented Aug 28, 2020

FYI: @matchings

In the process of testing: AllenInstitute/AllenSDK#1695 I discovered what looks to be bug in the visual_behavior implementation for getting a segmentation mask image.

See: https://gist.github.com/njmei/fe219cec20033e9817c89f5853b14692

In cell 3 of the gist I try using the visual_behavior method for accessing the segmentation mask image. The resulting mask image looks nothing like the average/max projection images.

In cell 6 of the gist I used only AllenSDK functions to get the segmentation mask image and got saner results.

@njmei njmei added the bug Something isn't working label Aug 28, 2020
@DowntonCrabby
Copy link
Collaborator

I'm wondering if the visual behavior method filters out invalid rois and the sdk version does not?

@njmei
Copy link
Collaborator Author

njmei commented Aug 28, 2020

Yes, it is likely the case that the SDK version does not filter out invalid ROIs.

That said, it looks like the segmentation mask images demonstrated in the gist are far too different for it to be simply an invalid ROI filtering issue. As an example, take a look at the top left corner of both images and you'll see that there does not seem to be any correspondence whatsoever...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants