Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validating that criteria are valid #23

Open
neuromusic opened this issue Jun 15, 2018 · 1 comment
Open

validating that criteria are valid #23

neuromusic opened this issue Jun 15, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@neuromusic
Copy link
Contributor

approach:

  • update mtrain_api to expose "valid" criteria through an endpoint
  • add pre-commit hook that ensures "conditions" are valid
@nicain
Copy link
Contributor

nicain commented Mar 15, 2019

Alternative strategy:

  • set a list of known criteria as a test fixture
  • write a test that inspects stages for conditions, and checks them against this list.

@nicain nicain self-assigned this Mar 15, 2019
@nicain nicain added the enhancement New feature or request label Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants